Fixes for test certificate download and handling #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Merged
hbldh
added a commit
that referenced
this pull request
May 7, 2023
- Merge of Update README.rst #41 - Merge of Update __init__.py #48 - Merge of Fixes for test certificate download and handling #50 Now bundles the Test certificate with the actual code so that test will work due to - Captcha prevents fetching of cert as before - openssh seems to fail to break p12 into pem files, so pem file were included as well. `certutils` needs to be examined in the near future. * Update README.rst Corrected typo in examples * Update __init__.py Fix breakage with urllib 2.0.x * Github Action fixes * Version bump * Bump reqs for example * Bundle the BankID Test certificate The BankID pages now returns a captcha instead of the actual certificate when fetching with requests. The actual cert is now bundled instead of fetched each time. * Failure detection in openssl test cert conversion * Add possibility to provide p12 test cert through existing file * Bundle the BankID Test certificate in pem format Bundle pem formats as well. * Python 2.7 compat. fix * Rmoving certutils test for the time being * Remove Python 2.7 support * Remove six dependency --------- Co-authored-by: Simon Olofsson <[email protected]> Co-authored-by: Colin 't Hart <[email protected]> Co-authored-by: Stefan Berg <[email protected]>
|
@1sfb This is now released to PyPI in version 0.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had some initial problems getting the test setup running due to triggering the CAPTCHA testing on the BankID end causing
the FPTestcert4_20220818.p12 downloaded by create_bankid_test_server_cert_and_key to contain the CAPTCHA test
instead.
This caused the openssl execution in split_certificate to silently fail, resulting in zero length certificate and key.
Added a bit of error handling to detect and raise an exception in split_certficate for subprocess errors, also added the
possibility to point the environment variable TEST_CERT_FILE to an existing p12 certificate file which will be used instead
of fetching the certificate (which got me out of the snag by letting me download the file from my browser instead).